-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove output
directive
#1354
Comments
@fwkoch is there anything downstream that might be using this? a unist select() one of the themes for example? or do you mean to remove the directive but maintain the node type? |
@stevejpurves your example is the output AST node which we do use, it's just the directive that's redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously, when ingesting jupyter notebooks for myst, we created an in-memory markdown "file." For cell outputs, the output data was moved to a cache, keyed off arbitrary
id
, then we used anoutput
directive in the markdown "file" with thatid
to inject the output back into the document... Now we just go straight from notebook to mdast; much more straight-forward and understandable, I think.However, the little
output
directive with only anid
is still lingering in ourmyst-directives
(and the docs!). This directive does not have any user-facing functionality and now has no internal functionality either. I think we should just remove it.The text was updated successfully, but these errors were encountered: