Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the test suite with Geth too #2626

Closed
axic opened this issue Jul 24, 2017 · 5 comments
Closed

Run the test suite with Geth too #2626

axic opened this issue Jul 24, 2017 · 5 comments

Comments

@axic
Copy link
Member

axic commented Jul 24, 2017

This depends on ethereum/interfaces#4 (i.e. agreeing on a test RPC class and implementing it in Geth).

Added here as a long term goal.

@chriseth
Copy link
Contributor

Is this about always running geth and cpp-ethereum as part of the CI? If yes, then I don't see the benefit. Whether or not the two clients produce the same result is not something that should be tested with the solidity CI, but with the cpp-ethereum / go-ethereum CI. We can provide scripts to run on demand, though.

Making soltest compatible with both cpp-ethereum and geth, on the other hand, is something we should do.

@axic
Copy link
Member Author

axic commented Aug 1, 2017

First, the RPC API must be defined and other clients need to support it. It would be useful for developers coming from other clients.

Second, I think running it with both Geth and Cpp is useful in CI, because despite best efforts in test case creation (ethereum-tests), even if a single test failure can be produced in Solidity in the future, it was worth the extra 2-3 minutes spent on CI.

@ekpyron
Copy link
Member

ekpyron commented Jun 13, 2019

They merged "retesteth" support in ethereum/go-ethereum#19631, so it might be worth looking into this again, since they now seem to implement most, if not all, of the RPC API we need for soltest.
EDIT: Adding this to the 0.5.10 project to stage it for reconsideration.

@chriseth
Copy link
Contributor

De-prioritizing because we probably want to switch to EVM-C first and then this should be easy to do.

@axic
Copy link
Member Author

axic commented Dec 12, 2019

This is now obsolete since we use EVMC + evmone.

@axic axic closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants