Add EIP: Two dimensional log filter data structure #8740
Merged
+363
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
abcoathup
reviewed
Jul 18, 2024
EIPS/eip-template.md
Outdated
| title: New log filter data structure | ||
| description: An efficient and light client friendly replacement for block header bloom filters | ||
| author: Zsolt Felföldi (@zsfelfoldi) | ||
| discussions-to: https://ethereum-magicians.org/t/new-log-filter-data-structure/20580 |
There was a problem hiding this comment.
Suggested change
| discussions-to: https://ethereum-magicians.org/t/new-log-filter-data-structure/20580 | |
| discussions-to: https://ethereum-magicians.org/t/eip-7745-new-log-filter-data-structure/20580 |
abcoathup
reviewed
Jul 18, 2024
EIPS/eip-template.md
Outdated
| @@ -0,0 +1,362 @@ | |||
| --- | |||
| title: New log filter data structure | |||
There was a problem hiding this comment.
Rather than "new", is there a better description for the proposed log filter data structure?
|
The commit 6220a07 (as a parent of 0896b5e) contains errors. |
g11tech
reviewed
Aug 3, 2024
EIPS/eip-7745.md
Outdated
|
|
||
| ## Test Cases | ||
|
|
||
| TODO |
There was a problem hiding this comment.
can you change todo references to:
<!-- TODO -->
which get flagged by CI if they are missed and EIP moved to review
There was a problem hiding this comment.
thanks, it is all green now.
eth-bot
approved these changes
Aug 15, 2024
Allzz77123
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An efficient and light client friendly replacement for bloom filters. This EIP proposes a new data structure that adds a moderate amount of consensus data that is optional to store long term, has limited processing and memory requirements and allows searching for log events with 2-3 orders of magnitude less bandwidth than what bloom filters allowed back when they were not rendered useless by over-utilization. It also inherently adapts to changing block utilization and maintains a constantly low average false positive ratio.
https://ethereum-magicians.org/t/eip-7745-two-dimensional-log-filter-data-structure/20580