Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBIOS library only works in STA mode, and not in AP mode. #5300

Closed
pabloandresm opened this issue Jun 17, 2021 · 2 comments
Closed

NetBIOS library only works in STA mode, and not in AP mode. #5300

pabloandresm opened this issue Jun 17, 2021 · 2 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@pabloandresm
Copy link

Title says it all. The problem is the same as the ESP8266NetBIOS library (esp8266/Arduino#8139).

If you look at the code, file NetBIOS.cpp, line 95, in the netbios answer, you can see:
nbnsa.addr = WiFi.localIP();

Which works only if WiFi is in STA mode, but not AP mode.

The fix would be something like this:
if (WiFi.getMode()==WIFI_STA)
nbnsa.addr = WiFi.localIP();
else
nbnsa.addr = WiFi.softAPIP();

@stale
Copy link

stale bot commented Aug 21, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Aug 21, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

1 participant