Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toogle the horizontal cursor movement #3

Closed
ramisedhom opened this issue Nov 20, 2020 · 12 comments
Closed

Toogle the horizontal cursor movement #3

ramisedhom opened this issue Nov 20, 2020 · 12 comments

Comments

@ramisedhom
Copy link

Obsidian v0.9.15
OS: Windows 10
Obsidian RTL Plugin v0.0.1

Steps

  1. Open file
  2. Press Ctrl+P and select "RTL Support: Switch Text Direction (LTR<>RTL)"
  3. File switch direction to RTL but cursor move still from left-to-right

Expected behavior
It's expected to toggle the horizontal cursor movement to be right-to-left as well.

Further analysis
As per CodeMirror User Manual, option 'rtlMoveVisually' control the horizontal cursor movement. Its default value is 'false' on Windows.

Suggestion
To add few lines to toggle 'rtlMoveVisually' along with the file 'direction' option.

esm7 added a commit that referenced this issue Nov 22, 2020
@esm7
Copy link
Owner

esm7 commented Nov 22, 2020

Should be fixed now but I don't have Windows to test it, please update to 0.0.2 and let me know.

@Ronsharo
Copy link

When you say "Open file" which file do you mean? And how do I open it? - Soryy, Im a newbe...

@esm7
Copy link
Owner

esm7 commented Nov 24, 2020

@Ronsharo these directions relate to recreating the bug, which is hopefully not relevant anymore.

@ramisedhom
Copy link
Author

@esm

Should be fixed now but I don't have Windows to test it, please update to 0.0.2 and let me know.

Thanks @esm7 very much for such fast support, I had updated the plugin to v0.0.2 and it works fine, except 1 small issue, pressing keyboard {Home} go to end of line and pressing keyboard {End} go to beginning of line. Is this reproducible at your end?

@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

@ramisedhom
Copy link
Author

@Ronsharo :

  1. From Obsidian, go to "Settings" > "Third-party plugins",
  2. Switch off "Safe mode" and click on "Community plugins" > "Browse",
  3. Find plugin "RTL Support" and click "Install"

@esm7
Copy link
Owner

esm7 commented Nov 24, 2020

@esm

Should be fixed now but I don't have Windows to test it, please update to 0.0.2 and let me know.

Thanks @esm7 very much for such fast support, I had updated the plugin to v0.0.2 and it works fine, except 1 small issue, pressing keyboard {Home} go to end of line and pressing keyboard {End} go to beginning of line. Is this reproducible at your end?

It happens to me too! I didn't notice it previously.
It seems to be an Obsidian behavior and not CodeMirror, I'll see if I can patch around it.
I opened a separate issue for this: #6

@esm7 esm7 closed this as completed Nov 24, 2020
@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

@Ronsharo
Copy link

Ronsharo commented Nov 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants