Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatESLintConfig does not support custom plugins #293

Closed
Dyskal opened this issue Apr 21, 2024 · 2 comments
Closed

FlatESLintConfig does not support custom plugins #293

Dyskal opened this issue Apr 21, 2024 · 2 comments

Comments

@Dyskal
Copy link

Dyskal commented Apr 21, 2024

Hi,
I was trying to use @eslint-types/typescript-eslint with flat config but I found that the plugin field does not support type augmentation

In FlatESLintConfig, it is:

plugins?: Record<string, ESLint.Plugin>;

Contrary to the legacy config in which it extends from LiteralUnion<keyof CustomPlugins>

Could you add support for plugin augmentation in flat config to make typescript-eslint plugin type work?
Thanks

@Shinigami92
Copy link
Collaborator

I'm more thinking about to deprecate eslint-define-config and shift work and effort to @typescript-eslint's config (typescript-eslint/typescript-eslint#8802 (comment))

@Dyskal
Copy link
Author

Dyskal commented Apr 22, 2024

I haven't saw this discussion!
I'll keep an eye on it then, thanks

@Dyskal Dyskal closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants