Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJS type declarations are not created #282

Closed
Lehoczky opened this issue Mar 30, 2024 · 2 comments
Closed

CJS type declarations are not created #282

Lehoczky opened this issue Mar 30, 2024 · 2 comments

Comments

@Lehoczky
Copy link
Contributor

When dual-publishing libraries, CJS and MJS bundles must have different .d.ts files. Currently there is only type declaration file, which is for the MJS bundle.

Checked with:

PR is coming with the fix:)

@Shinigami92
Copy link
Collaborator

These types are not required and it is just a warning that can be ignored.
It only makes sense if the types differ from each other, but the emitted types are almost always the same and so would only double the bundle size.

So unless you proof me wrong, I would like to reject this PR.

@Lehoczky
Copy link
Contributor Author

'Mkay for me!

@Shinigami92 Shinigami92 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants