Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.24.1 prevents installing on node 16 #244

Closed
satouriko opened this issue Oct 17, 2023 · 3 comments
Closed

v1.24.1 prevents installing on node 16 #244

satouriko opened this issue Oct 17, 2023 · 3 comments

Comments

@satouriko
Copy link

This version (commit e23b186#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L121) drops node 16 support and breaks our project, as we depends on @vue/eslint-config-airbnb-with-typescript that depends on eslint-define-config@^1.6.0.
We still need node 16 because of issue with webpack (webpack/webpack#14532) :(
This breaking change seems unintentional and released with a patch version, is it necessary to drop node 16 support? Could we add back node 16 to the engines field and/or move the incompatible changes to a major version?

@sxzz
Copy link
Collaborator

sxzz commented Oct 17, 2023

What are you using package manager? Have you tried --ignore-engines flag (yarn)?
See https://stackoverflow.com/a/45088032

@Shinigami92
Copy link
Collaborator

The change actually was intent
NodeJS 16 reached end of life and so is officially not supported anymore
If you have an issue with webpack and/or your project setup, please report that to the related projects
Please also upgrade to NodeJS 18+ immediately due to secure software architecture

@Shinigami92 Shinigami92 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
@Shinigami92
Copy link
Collaborator

Oh by the way, if you can rely on webpack and NodeJS 16, you also don't need to update your eslint-define-config version and just pin it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants