Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined string configurations in flat config seem to be deprecated #226

Closed
DamianGlowala opened this issue Aug 24, 2023 · 3 comments · Fixed by #227
Closed

Predefined string configurations in flat config seem to be deprecated #226

DamianGlowala opened this issue Aug 24, 2023 · 3 comments · Fixed by #227

Comments

@DamianGlowala
Copy link

When using:

export default ['eslint:recommended']

... I receive:

The 'eslint:recommended' string configuration is deprecated and will be replaced by the @eslint/js package's 'recommended' config.

Shall the following type be removed?
https://github.com/Shinigami92/eslint-define-config/blob/2eac0b22b1c7f22487a32dc7ccf6476a73fb7765/src/flat-config/index.d.ts#L73

@Shinigami92
Copy link
Collaborator

First time hearing about https://www.npmjs.com/package/@eslint/js at all ^^
Not sure if we need backwards compatibility for older eslint versions there 🤔
I think right now it is mostly used with LiteralUnion, is it? So it's just a suggestion.
Is it a hard break since a specific version of FlatConfig? I'm not used to FlatConfig until today at all.

/ping @sxzz

@DamianGlowala
Copy link
Author

I think I found the relevant commit and issue:

eslint/eslint@c8c0c71
eslint/eslint#16537

I would certainly remove it only from the flat config types :)

@sxzz
Copy link
Collaborator

sxzz commented Aug 24, 2023

(node:75845) Warning: The 'eslint:recommended' string configuration is deprecated and will be replaced by the @eslint/js package's 'recommended' config.

Predefined string configurations are not removed by ESLint official but deprecated. Maybe we can mark it deprecated in jsdoc, and remove them after ESLint did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants