-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring generation script #134
Comments
Lol 😂... my thought was more like: if you do all the PRs and Issues in a good way, I'm willing to sponsor you 1-2 cups of Coffee ☕️ / ~10€ 💸 But yes, please use Vitest. I use it in all my projects since Vitest was created. Feel also free to split the generate file into more smaller pieces and maybe generate also settings and such out from a plugin. |
Haha okay, cool, thanks a lot man. I just didn't want to be too intrusive 😋 |
I also think about to provide a param to the script so only one given plugin will get generated / updated instead of all at once |
I think it would be cool to do a good refactoring of the type generation script (
scripts/generate-rule-file.ts
).Currently, for a newcomer to the codebase ( like me 😋 ), it's quite complicated to understand/maintain or extend. And this is the core of eslint-define-config.
If you're interested I can try to propose a PR with something cleaner ( from my POV ), when I have some time to do it. And by the way, adding some tests would be awesome.
Since you are very active in the Vite ecosystem, I imagine that you would be more in favor of using Vitest.
However, I would still like to suggest to use Japa, a test runner that I help to maintain and make evolve. It is a test runner that is focused on testing NodeJS libs/applications, and that does not perform any code transformation.
However, if you prefer Vitest, no worries, it is also a tool that I absolutely love. 💖
Feel free to close the issue if you are not interested, no worries !
The text was updated successfully, but these errors were encountered: