Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support flat config #145

Merged
merged 6 commits into from
Oct 23, 2022
Merged

feat: support flat config #145

merged 6 commits into from
Oct 23, 2022

Conversation

sxzz
Copy link
Collaborator

@sxzz sxzz commented Oct 21, 2022

@Shinigami92 Shinigami92 added the enhancement New feature or request label Oct 21, 2022
src/index.js Outdated Show resolved Hide resolved
src/flat/index.d.ts Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Collaborator

@sxzz I'm not sure about the term legacy 🤔
Is it coming from ESLint? Or did you came up with this term?

@sxzz
Copy link
Collaborator Author

sxzz commented Oct 21, 2022

@Shinigami92 According to the blog, I think flat config is the future. Actually, I'm not sure, but it has to get a name. What name do you prefer?
legacy, nested, or something else?

@Shinigami92
Copy link
Collaborator

@Shinigami92 According to the blog, I think flat config is the future. Actually, I'm not sure, but it has to get a name. What name do you prefer? legacy, nested, or something else?

Ah yeah, then I'm against legacy as it indicates now as it would be deprecated, but it is not. The new FlatConfig is just the new way for now.

For now I wouldn't change it at all and just stick with config and flat-config and use this terminology the whole way down.
Like ESLintConfig and FlatESLintConfig and so on.

... And oh yeah, please use FlatESLintConfig instead of ESLintFlatConfig as this is what they call it:

image

@sxzz
Copy link
Collaborator Author

sxzz commented Oct 21, 2022

@Shinigami92 I agree with you. I will change it

@Shinigami92
Copy link
Collaborator

I have some Meetings and Company Work today, if I find the time this evening, I will release your (welcome 🤗) additions 👍
(I'm in German TimeZone)

@sxzz sxzz requested a review from Shinigami92 October 21, 2022 07:53
@sxzz
Copy link
Collaborator Author

sxzz commented Oct 21, 2022

@Shinigami92 OK thanks~

@Shinigami92 Shinigami92 merged commit ff6bd71 into eslint-types:main Oct 23, 2022
@sxzz sxzz deleted the feat/flat branch October 23, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new ESLint config
2 participants