Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Leap-Seconds #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(WIP) Leap-Seconds #25

wants to merge 2 commits into from

Conversation

darioizzo
Copy link
Member

In the attempt to have leap seconds correctly accounted for in pykep, this PR adds a number of tests in the c++ side that should pass but do not.

Any attempt to fix the leap second issue should tackle these tests

@darioizzo darioizzo changed the title tests that should but do not pass (WIP) Leap-Seconds Oct 16, 2023
@cantordust
Copy link
Collaborator

As far as I can tell, leap seconds are not supported by std::chrono::system_clock. It might be necessary to move to std::chrono::utc_clock, but I don't think it is guaranteed to use UNIX time as the reference point, so the arithmetic might become wonky.

@darioizzo
Copy link
Member Author

I think we decided to have kep3:

  1. Use the Gregorian Proleptic Calendar (i.e. before the year 1400 will give weird answer if compared to what was in use ,i.e. the Julian).
    1bis) Referred to the Greenwich timezone only.
  2. Ignore entirely leap seconds.

So I guess this PR can be closed @bluescarni ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants