-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src_tests option for Relx could be very slow but enabled by default #2820
Comments
@tsloughter do you recall what that function plays? Validating source paths? |
eeeek 30 seconds!? Maybe rebar3 should set it to false by default and relx not? My thinking there is that since rebar3 already does the compilation step its job is to ensure source and object files are up to date and not relx's, so it can be skipped in relx. |
That's a good call out yeah, under that mechanism we could switch the default since we track it all. |
Description
rebar3 release
runs 30 seconds faster for MongooseIM after settingsrc_tests
option tofalse
in relx.Detailed explanation esl/MongooseIM#4099
Expected behaviour
src_tests could be disabled by default.
Or we can write in docs that it is very slow.
We could alternatively add a warning suggesting that the option could be disabled, if making script file takes more than 5 seconds.
Maybe relx repo is the better place for this issue.
The text was updated successfully, but these errors were encountered: