Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json encode_map_checked encode_key_value_list_checked #8519

Merged

Conversation

dgud
Copy link
Contributor

@dgud dgud commented May 28, 2024

They where missing the enclosing curly parenthesis.

They where missing the enclosing curly parenthesis.
@dgud dgud added the team:PS Assigned to OTP team PS label May 28, 2024
@dgud dgud self-assigned this May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit e0bed5b

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@dgud
Copy link
Contributor Author

dgud commented May 28, 2024

Ping @michalmuskala

@dgud dgud changed the base branch from maint-27 to maint May 28, 2024 12:04
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label May 28, 2024
Copy link
Contributor

@michalmuskala michalmuskala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dgud dgud merged commit 948e3ad into erlang:maint Jun 11, 2024
12 of 14 checks passed
williamthome added a commit to williamthome/json_polyfill that referenced this pull request Jul 27, 2024
williamthome added a commit to williamthome/json_polyfill that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants