-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's version this! #516
Comments
I agree let's make it happen |
@quicksnap thanks for tackling this! considering the fast-moving nature of the this repo, ecosystem and dependencies i definitely support versioning... as far as outstanding tasks, in my opinion #402 might be a little ambitious for a first release. i think the most important issue right now is getting babel 6 integrated and stable #488. we're currently in a holding pattern until |
@justingreenberg do you think we could stamp a version without upgrading to babel 6? I feel it's still a little fresh. Perhaps we can do a next version once the ecosystem around it has stabilized. |
I agree that this is needed. I'm fine with stamping it with one now. It's never going to be "complete", of course. Is |
Done. Since this is not a library, it only makes vague sense to follow some semblance of semver. I'm going to need some help writing the release pages and any "migration guides", since I don't have time to follow every single improvement. |
|
@erikras that's completely understandable the redux ecosystem is moving so quickly, i think versioning this repo is really about tracking patches and general updates as best practices continue to emerge—which is especially important for people using this as a starter. since it's not a library, i don't think we need to worry too much about migration guides. that said, it might be a good idea to set some basic contributing guidelines ie to normalize the commit log. personally i've always been a fan of angular's commit message guidelines where commit messages generally conform to
EDIT: added in #523 (merged) @quicksnap with respect to the babel migration, when i was putting together a PR last week all of our plugins already supported the v6 api, except typecheck (which released support yesterday) and react-transform, which should be updated this week |
I still am unsure of the best way to handle something like a migration guide. This repo moves pretty fast, and I feel that's part of its value. If we do some work on reorganizing some things, and guard against unnecessary refactoring, tracking upstream changes shouldn't be terribly hard. |
@justingreenberg that's good news with babel! Worth the wait, then.. |
I'm curious if anyone who was interested in versioning has could have a look into #626 as solving these needs. It's along the lines of consolidating parts of this project into a library. @erikras @justingreenberg @quicksnap |
I'll try and take a look sometime this week--just been busy with work and unable to look at large changes. |
Let's shore up any big issues and stamp a version on this. This issue covers the following:
Some goals:
The text was updated successfully, but these errors were encountered: