Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential security issue #76

Open
ghost opened this issue Jan 26, 2024 · 0 comments
Open

Potential security issue #76

ghost opened this issue Jan 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 26, 2024

Checking event.getView().getTitle() to see whether your custom inventory is being used is unsafe, as renaming a chest in an anvil allows users to set their own inventory titles. The correct way to check if your custom inventory is involved with an event is by using custom holders, see here: https://docs.papermc.io/paper/dev/custom-inventory-holder

if (event.getView().getTitle().equals(TargetSelectInventory.INVENTORY_NAME)) {

@ghost ghost added the bug Something isn't working label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants