Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High penalty implementation looks wrong #6

Open
rkreddy82 opened this issue Apr 9, 2020 · 1 comment
Open

High penalty implementation looks wrong #6

rkreddy82 opened this issue Apr 9, 2020 · 1 comment

Comments

@rkreddy82
Copy link

in disprange_aggregation function

following statement
if((A[current_path][curx][cury-direction_y][pdisp]+LARGE_PENALTY)<term_1)

should be
if((A[current_path][curx-direction_x][cury-direction_y][pdisp]+LARGE_PENALTY)<term_1)

can some body clarify

@Willyzw
Copy link

Willyzw commented Jan 14, 2021

I can confirm the flaw. But the weird thing is that the disparity map generated with the fix is worse (less smoothed and many holes) than the original one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants