-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2d plotting with a 3d coordinate set# #26
Comments
Thanks for your suggestion @stanleyjs. I agree with your point, and in general graphs might even be embedded in more that 3D. Then, is it better to:
(1) assumes that What's your thoughts? |
So as it stands (2) is essentially already in place, we just don't have a So (1) requires new plotting logic, new dimension checking logic in I will note that adding the keyword arg (1) does not completely abrogate (2). |
I hear your arguments. If we can have a nice implementation and not a hack that'll add to our technical debt I'd be willing to accept a PR. I think the default should be to plot with all the dimensions available in While doing that, we could add an Passing |
I would like to plot only two of a graph's dimensions. Oftentimes this is desirable because working in 3D can be hard to wrap one's head around. This would be something like a keyword argument
g.plot(dims=[1,2])
or such.I poked my head in the plotting code and it appears that the bulk of the logic in the
_plt*
and_qtg*
functions are built atop calls to_get_coords(G)
and conditionals onG.coords.shape
. This makes it a little bit difficult to just insert adims
parameter. It could be done, but it'd require a refactor. One hacky option is to alter_plot_graph
and_plot_signal
(and their upstream methods ingraphs.py
), to havedims=None
as a keyword parameter and haveNote that this doesn't consume any extra memory due to assignment by reference.
The text was updated successfully, but these errors were encountered: