-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module 'react' from 'ReactSixteenAdapter.js' #1954
Comments
It being a peer dependency means you have to explicitly have it as a dep or dev dep on the top level. Have you? Note that everything that’s not the top level app should have it as a peer dep (and dev dep) and not as a regular dep. |
I have component as a package and I want to test it, can you suggest best way how to be? |
In that case, your package must have react as both a peer dep and a dev dep - the dev dep for testing, the peer dep to communicate compatibility to consumers. |
@ljharb okey, it's work, thank you for help 👍 |
Hi @ljharb , I ran into the same issue with I have it in my dep an devdep
but I still go the error:
Any idea why? |
To use RN, you'd need an actual RN adapter - see #1436 for that. |
Hi, I have some issue in my project about react high order component. I think it's because react moved in peerDependencies.
More logs:
https://travis-ci.com/Luchanso/react-has-mounted/builds/95682075#L456-L462
Pull Request with changes.
Version
Adapter
The text was updated successfully, but these errors were encountered: