-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inventory_cache
arg to sphinx_runner
#461
Comments
Seems like this is not what is required. Sphinx config allows you to specify (multiple) sources for the What we do need is something to download (and maybe sync) the inv files |
closed in favour of #462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
sphinx_runner
reads a config file in the Envoy/website repos and downloads the inventories on every docs buildIt would be useful to add an
inventory_cache
arg that read from a directory and/or tarball to find the inventory filesthis would allow bazel some control over how the inventories were fetched/found
in the case of the website the inventory files are present in the repo/workspace so they can be used directly
for Envoy, probably the best plan is to add them directly to the repo as they rarely change, but the challenge here is that we would then need CI to ensure this was up to date
one option would be to add a
--strict-inventory-cache
or similar that made sure that all/only the expected inventory files were presentThe text was updated successfully, but these errors were encountered: