Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stats] - Quartiles graphs #4

Open
nrshrivatsan opened this issue Apr 22, 2018 · 3 comments
Open

[Stats] - Quartiles graphs #4

nrshrivatsan opened this issue Apr 22, 2018 · 3 comments

Comments

@nrshrivatsan
Copy link

TL;DR

  • Inline color-coded Quartile [ p25,p50,p75,p95 ]

Mock

envoy-curses-metrics-quartiles

Background

  • Current visualization is rudimental for operations! 😄 👍
    image

  • Quartiles made navigable via arrow-keys ⬇️ ↔️ would be extremely valuable and insightful for Envoy-Operators.

envoy-curses-metrics-quartiles

  • Also making these configureable via CLI input for the NODE-JS code would be elegant.
@mattklein123
Copy link
Member

This would be awesome! Especially now that we have histograms...

@nrshrivatsan
Copy link
Author

@mattklein123 thanks for taking time to comment.

We have two options:

  1. Patch NodeJS code in envoy-curses to render the values as percentiles
  2. Patch Envoy-Proxy metrics to also expose Percentiles

Your vote?

@mattklein123
Copy link
Member

@nrshrivatsan I'm not sure I follow. We already output percentile data from Envoy stats endpoints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrshrivatsan @mattklein123