Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include term in report by default #1668

Open
lcarva opened this issue Jun 5, 2024 · 5 comments
Open

Include term in report by default #1668

lcarva opened this issue Jun 5, 2024 · 5 comments
Assignees

Comments

@lcarva
Copy link
Member

lcarva commented Jun 5, 2024

Any violations/warnings reported by the ec validate image via the yaml or json output format do not include the corresponding term by default. This can only be seen when providing the --info flag. term is an important attribute of a violation/warnings since it can be used in include/exclude causes.

Acceptance Criteria

  • Include term, if any, be default for violations and warnings.
@Arpit529Srivastava
Copy link

i can resolve the issue @lcarva please assign it to me with hacktoberfest label.
thank you

@lcarva
Copy link
Member Author

lcarva commented Oct 1, 2024

Done. Looking forward to seeing the PR.

@Arpit529Srivastava
Copy link

needed a head start where I can make the changes and in which file?
@lcarva help needed

@lcarva
Copy link
Member Author

lcarva commented Oct 3, 2024

Likely here:

func keepSomeMetadataSingle(result evaluator.Result) {
for key := range result.Metadata {
if key == "code" || key == "effective_on" {
continue
}
delete(result.Metadata, key)
}
}

@Arpit529Srivastava
Copy link

@lcarva got it
will be putting up the pr in 10min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants