-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Deduct unit
from metric name and apply unit to value.
#222
Comments
I think having two values,
|
With my solution I had code size, RAM and network impact in mind. Two k/v pairs per metric is a much cleaner approach of course but has less likelihood of being merged into Tasmota. I'd be ok with either solution as long as this dreaded problem (measurements without units) is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implementation of sensor.py is trying to match exact metric name to predefined list. If it matches a preconfigured unit is applied. All other metrics have no unit at all.
To keep the current JSON format compatible I vote for a naming pattern like "%%". This (or a similar) pattern could easily be provided in the JSON payload by SMI.
sensor.py would need to subtract "%%" from the metrics name and apply the according unit the value.
My Tasmota installation reads three meters and provides their readings like this:
The text was updated successfully, but these errors were encountered: