Don't set span status to OK on every successful trace stopping

[bidetofevil]

Goal

Don't explicit set the status of a span when we call end() in EmbraceSpan. This means that UNSET will be a valid status value for a completed span, per OTLP.

Testing

Fixed up tests to not look for OK status to denote a completed span, but rather that an end time has been set.

[bidetofevil]

• Refactor how span status is peristed and sent to sdk span from wrappers #967
• Don't set span status to OK on every successful trace stopping #966 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (eea96b9) to head (7ce1a35).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   80.90%   81.03%   +0.13%     
==========================================
  Files         444      444              
  Lines       11824    11824              
  Branches     1807     1807              
==========================================
+ Hits         9566     9582      +16     
+ Misses       1465     1448      -17     
- Partials      793      794       +1     

Files	Coverage Δ
...io/embrace/android/embracesdk/anr/AnrOtelMapper.kt	87.17% <100.00%> (ø)
.../android/embracesdk/anr/ndk/NativeAnrOtelMapper.kt	77.19% <100.00%> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt	84.74% <100.00%> (-0.26%)	⬇️
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt	86.61% <100.00%> (-0.11%)	⬇️
...mbrace/android/embracesdk/opentelemetry/EmbSpan.kt	91.66% <66.66%> (+0.49%)	⬆️

... and 5 files with indirect coverage changes

[fractalwrench]

LGTM