Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set network spans with non-successful error codes as failed #962

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jun 12, 2024

Goal

Set the status of a network span based on the http status code

Testing

Updated unit and integration tests to verify this

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil marked this pull request as ready for review June 13, 2024 00:00
@bidetofevil bidetofevil requested a review from a team as a code owner June 13, 2024 00:00
@bidetofevil bidetofevil requested a review from priettt June 13, 2024 00:00
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (bb68873) to head (b0e66b3).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   80.91%   81.02%   +0.10%     
==========================================
  Files         445      445              
  Lines       11827    11834       +7     
  Branches     1806     1807       +1     
==========================================
+ Hits         9570     9588      +18     
+ Misses       1462     1452      -10     
+ Partials      795      794       -1     
Files Coverage Δ
...dk/network/logging/EmbraceNetworkLoggingService.kt 96.55% <80.00%> (-3.45%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove extra between bracket and variable
@bidetofevil bidetofevil merged commit e3ab4c7 into master Jun 13, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/network-span-status branch June 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants