Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc style updates #922

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

I've broken style updates out of #914 to reduce the size of the changeset.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (ce0a64f) to head (37dbdce).
Report is 3 commits behind head on integration/v2-migration.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           integration/v2-migration     #922      +/-   ##
============================================================
- Coverage                     80.79%   80.75%   -0.04%     
============================================================
  Files                           436      436              
  Lines                         11602    11606       +4     
  Branches                       1776     1777       +1     
============================================================
- Hits                           9374     9373       -1     
- Misses                         1440     1446       +6     
+ Partials                        788      787       -1     
Files Coverage Δ
...io/embrace/android/embracesdk/anr/AnrOtelMapper.kt 87.17% <100.00%> (ø)
.../embracesdk/comms/delivery/DeliveryCacheManager.kt 100.00% <ø> (ø)
...mbrace/android/embracesdk/internal/payload/Span.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/payload/SpanEvent.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 83.15% <50.00%> (ø)
.../android/embracesdk/anr/ndk/NativeAnrOtelMapper.kt 77.19% <0.00%> (ø)
.../android/embracesdk/internal/payload/SpanMapper.kt 64.81% <71.42%> (ø)
...mbracesdk/comms/delivery/EmbraceDeliveryService.kt 58.46% <20.00%> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 72.58% <0.00%> (-6.37%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e28f129 into integration/v2-migration Jun 6, 2024
2 of 3 checks passed
@fractalwrench fractalwrench deleted the style-updates branch June 6, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants