Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to rename spans that have not ended #903

Merged
merged 1 commit into from
May 30, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented May 29, 2024

Goal

Add the ability to rename a span that hasn't been stopped. This is so we can expose this functionality in our OTel Span API wrapper.

Testing

Added unit tests

Copy link
Collaborator Author

bidetofevil commented May 29, 2024

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as an implementation but I have a question about whether this is necessary as a feature. Are customers likely to actually do this?

Copy link
Collaborator Author

It's part of the OTel Span API and something iOS already supports. I don't know if customers will use it, but it's part of the API and it's relatively easy to implement (without needing anything on the server), so I just did it to reduce on area of potential differentiate between our implementation and the official Java OTel SDK's.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.87%. Comparing base (9ab695e) to head (ba3640d).
Report is 2 commits behind head on master.

Current head ba3640d differs from pull request most recent head e9878be

Please upload reports for the commit e9878be to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   80.82%   80.87%   +0.05%     
==========================================
  Files         437      437              
  Lines       11649    11660      +11     
  Branches     1777     1784       +7     
==========================================
+ Hits         9415     9430      +15     
+ Misses       1444     1443       -1     
+ Partials      790      787       -3     
Files Coverage Δ
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 85.71% <ø> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 85.24% <93.33%> (+1.60%) ⬆️
...droid/embracesdk/internal/spans/SpanServiceImpl.kt 88.00% <33.33%> (+1.72%) ⬆️

... and 2 files with indirect coverage changes

Base automatically changed from hho/attributes-to-map to master May 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants