-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to rename spans that have not ended #903
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on Graphite |
e7c03e1
to
872b6f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an implementation but I have a question about whether this is necessary as a feature. Are customers likely to actually do this?
593c2df
to
d2366f7
Compare
872b6f2
to
ba3640d
Compare
It's part of the OTel Span API and something iOS already supports. I don't know if customers will use it, but it's part of the API and it's relatively easy to implement (without needing anything on the server), so I just did it to reduce on area of potential differentiate between our implementation and the official Java OTel SDK's. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 80.82% 80.87% +0.05%
==========================================
Files 437 437
Lines 11649 11660 +11
Branches 1777 1784 +7
==========================================
+ Hits 9415 9430 +15
+ Misses 1444 1443 -1
+ Partials 790 787 -3
|
ba3640d
to
e9878be
Compare
Goal
Add the ability to rename a span that hasn't been stopped. This is so we can expose this functionality in our OTel Span API wrapper.
Testing
Added unit tests