Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal errors with OTel logs #887

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Replace internal errors with OTel logs #887

merged 1 commit into from
Jun 10, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Replaces internal errors with OTel logs.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 24, 2024 13:07
bidetofevil
bidetofevil approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 6e944e9 into initial-otel-internal-errors Jun 10, 2024
1 check failed
@fractalwrench fractalwrench deleted the internal-error-otel branch June 10, 2024 13:18
fractalwrench added a commit that referenced this pull request Jun 10, 2024
@fractalwrench
Merge pull request #887 from embrace-io/internal-error-otel
6e791fb 
Replace internal errors with OTel logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @bidetofevil