Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test expected file #836

Merged
merged 1 commit into from
May 14, 2024
Merged

Update test expected file #836

merged 1 commit into from
May 14, 2024

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented May 10, 2024

Goal

Removing unused values form expected json file.

Testing

Unit test.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite Graphite

@nelsitoPuglisi nelsitoPuglisi changed the title update test Update test expected file May 10, 2024
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review May 10, 2024 17:34
@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner May 10, 2024 17:34
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (76ab112) to head (47e694c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   81.35%   81.28%   -0.08%     
==========================================
  Files         423      423              
  Lines       11416    11416              
  Branches     1696     1696              
==========================================
- Hits         9288     9280       -8     
- Misses       1419     1429      +10     
+ Partials      709      707       -2     

see 3 files with indirect coverage changes

@nelsitoPuglisi nelsitoPuglisi merged commit 77cd898 into master May 14, 2024
6 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/unused-values branch May 14, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants