Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote config that controls whether v2 payload is sent or not #560

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Add remote config that controls whether a v2 session payload is sent or whether the SDK should default to the v1 payload scheme. This changeset defaults to using v1 but this will change soon once the new payload class is fully hooked up.

Testing

Added unit tests.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 15:20
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

LGTM

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.22%. Comparing base (4768398) to head (3755a17).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           collator-module     #560      +/-   ##
===================================================
- Coverage            80.24%   80.22%   -0.03%     
===================================================
  Files                  413      413              
  Lines                11022    11024       +2     
  Branches              1618     1619       +1     
===================================================
- Hits                  8845     8844       -1     
  Misses                1532     1532              
- Partials               645      648       +3     
Files Coverage Δ
...id/embracesdk/config/remote/SessionRemoteConfig.kt 100.00% <100.00%> (ø)
...roid/embracesdk/config/behavior/SessionBehavior.kt 75.00% <0.00%> (-3.27%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from collator-module to master March 14, 2024 06:46
@fractalwrench fractalwrench merged commit 3ad0571 into master Mar 14, 2024
3 checks passed
@fractalwrench fractalwrench deleted the add-payload-flag branch March 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants