Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Log Payload Source to build the Log Envelope #554

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

lucaslabari
Copy link
Contributor

Goal

  • Added the implementation to LogPayloadSourceImpl so we can build the envelope for Logs.

Testing

Added unit tests

@lucaslabari lucaslabari requested a review from a team as a code owner March 12, 2024 21:11
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (033a88b) to head (9a09bf0).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   80.12%   80.17%   +0.05%     
==========================================
  Files         412      412              
  Lines       10986    10989       +3     
  Branches     1617     1617              
==========================================
+ Hits         8802     8810       +8     
+ Misses       1538     1535       -3     
+ Partials      646      644       -2     
Files Coverage Δ
...d/embracesdk/capture/envelope/LogEnvelopeSource.kt 100.00% <100.00%> (ø)
...cesdk/capture/envelope/log/LogPayloadSourceImpl.kt 100.00% <100.00%> (ø)
...race/android/embracesdk/injection/PayloadModule.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/payload/LogMapper.kt 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaslabari lucaslabari merged commit 2f6c705 into master Mar 13, 2024
4 checks passed
@lucaslabari lucaslabari deleted the lucas/implement_log_payload_source branch March 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants