Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove real 68k #147

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Remove real 68k #147

wants to merge 14 commits into from

Conversation

SegHaxx
Copy link

@SegHaxx SegHaxx commented Dec 5, 2020

Alright, this fork seems eager to tear out old legacy code, so lets do it. This tears out "real" 68k support.

@SegHaxx
Copy link
Author

SegHaxx commented Dec 5, 2020

As expected this breaks things I didn't test. Whats up with windows?

@SegHaxx SegHaxx marked this pull request as draft December 5, 2020 23:19
@ianfixes
Copy link
Member

ianfixes commented Dec 6, 2020

From the Details it looks related to 68k

prefs_editor_gtk.cpp: In function 'void create_memory_pane(GtkWidget*)':
prefs_editor_gtk.cpp:1691:4: error: 'STR_CPU_68020_LAB' was not declared in this scope
 1691 |   {STR_CPU_68020_LAB, GTK_SIGNAL_FUNC(mn_cpu_68020)},
      |    ^~~~~~~~~~~~~~~~~
prefs_editor_gtk.cpp:1692:4: error: 'STR_CPU_68020_FPU_LAB' was not declared in this scope
 1692 |   {STR_CPU_68020_FPU_LAB, GTK_SIGNAL_FUNC(mn_cpu_68020_fpu)},
      |    ^~~~~~~~~~~~~~~~~~~~~
prefs_editor_gtk.cpp:1693:4: error: 'STR_CPU_68030_LAB' was not declared in this scope
 1693 |   {STR_CPU_68030_LAB, GTK_SIGNAL_FUNC(mn_cpu_68030)},
      |    ^~~~~~~~~~~~~~~~~
prefs_editor_gtk.cpp:1694:4: error: 'STR_CPU_68030_FPU_LAB' was not declared in this scope
 1694 |   {STR_CPU_68030_FPU_LAB, GTK_SIGNAL_FUNC(mn_cpu_68030_fpu)},
      |    ^~~~~~~~~~~~~~~~~~~~~
prefs_editor_gtk.cpp:1695:4: error: 'STR_CPU_68040_LAB' was not declared in this scope
 1695 |   {STR_CPU_68040_LAB, GTK_SIGNAL_FUNC(mn_cpu_68040)},
      |    ^~~~~~~~~~~~~~~~~
prefs_editor_gtk.cpp:1700:2: error: 'active' was not declared in this scope; did you mean 'ctime'?
 1700 |  active = 0;
      |  ^~~~~~
      |  ctime

@ianfixes
Copy link
Member

ianfixes commented Dec 6, 2020

The goal isn't necessarily to remove legacy code, it's to remove anything that can't be (at the very least) compile-tested on modern CI/CD. I'm not opposed to spinning up some sort of emulator in a build agent to run an older OS's compiler against this code; my feeling is that if we can't support a more collaborative development cycle for the code (i.e. if changes require a specific individual with hardware access to make dedicated time to test contributions), we can't support the code itself.

Can you check whether the README or other documentation will be affected by this change?

@SegHaxx
Copy link
Author

SegHaxx commented Dec 6, 2020

I think we're on the same page. I mean, I gave away my nice 40mhz chipped Quadra 630 when I moved 10 years ago, with the expectation that I could use Basilisk II on whatever hardware I had in the future. :)

Anyone still running NetBSD on an Amiga can fork whatever old version of Basilisk II. I'm moving forward with modernization. :)

Re-writing docs needs to be done, yes.

@SegHaxx SegHaxx marked this pull request as ready for review December 10, 2020 00:53
@SegHaxx SegHaxx marked this pull request as draft December 10, 2020 00:55
@SegHaxx SegHaxx marked this pull request as ready for review December 11, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants