Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_VERSION_ATLEAST outside of USE_SDL case #134

Open
rakslice opened this issue Oct 15, 2020 · 4 comments
Open

SDL_VERSION_ATLEAST outside of USE_SDL case #134

rakslice opened this issue Oct 15, 2020 · 4 comments
Labels
bug Something isn't working make Affects Makefiles or other build system components

Comments

@rakslice
Copy link
Contributor

#if __MACOSX__ && SDL_VERSION_ATLEAST(2,0,0)

SDL_VERSION_ATLEAST(x,y,z) tests should be inside a USE_SDL case, because SDL_VERSION_ATLEAST is defined in SDL headers and won't even compile if you're building without SDL.

@rakslice
Copy link
Contributor Author

For an example of an SDL_VERSION_ATLEAST that is properly inside an #ifdef block see the other two uses of it in the file ;)

@ianfixes
Copy link
Member

Thanks for contributing this! I've been trying to get this project to a CI-able state and it's been tough.

Before the lockdown hit, I was making plans to convert this over to CMake, as the existing build system is homemade and "quirky" to say the least.

I had a lot of trouble getting SDL to even install / build with this project in Appveyor too. Is the error message in #83 one that you recognize?

@ianfixes ianfixes added bug Something isn't working make Affects Makefiles or other build system components labels Oct 15, 2020
@rakslice
Copy link
Contributor Author

#83 ? I don't see a mention of an error there.

I took a glance at the Windows builds linked from https://github.com/emaculation/macemu previously and was confused about the state of the build jobs because they say 'MSYS' but are using Cygwin, not MSYS

@rakslice
Copy link
Contributor Author

I'll talk more about it on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working make Affects Makefiles or other build system components
Projects
None yet
Development

No branches or pull requests

2 participants