-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping $edit:close-mode~
has no effect
#1798
Comments
Ctrl-Q is most likely reserved for flow control by the terminal driver, so you can't bind it to anything. Try another key like |
I'll close this because it's a terminal issue - in the meantime I've added some notes to https://elv.sh/ref/edit.html#format-of-keys that some keys may not be available due to limitations of the terminal. |
I've also removed the doc for edit:completion:close. |
thank you! for your prompt responses and actions :)) |
But it's weird that |
Yes - these are all the termios manipulation Elvish does: elvish/pkg/cli/term/setup_unix.go Lines 24 to 36 in a03125e
I haven't really dug deep enough into termios stuff to know whether it's safe for Elvish to always disable IXON. I guess you can always call |
yes. Fish is valued for its better defaults over zsh. I think keymaps should take precedence over old features – most people won't know it's there, but those who do should know exactly what they're missing. I don't think this specialised piece of knowledge should be required by default. |
Nice, I filed #1803. The user would still need to know quirks like Ctrl-I being identical to Tab, but at least we get two keys back. |
Yess, but they won't need to learn about the historical curiosities of flow control! And when Kitty keyboard protocol is implemented, even Ctrl-I will go away. |
If they use a terminal that supports the kitty protocol... which none of the more mainstream ones support yet :-/ In any case it's a small incremental improvement, but Elvish is just a small piece of the puzzle. |
As I understand, looking at readline-binding.elv,
$edit:close-mode~
should close all non-insert modes back to insert-mode. (and $edit:completion:close~ has been removed, right?)I am trying to remap
C-q
to do the same thing. I tryand others, but none of them have any effect: while
C-g
continues to close modes,C-q
does nothing.Am I doing something wrong?
The text was updated successfully, but these errors were encountered: