New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong timezone conversion to radian #1

Open

pham-tuan-binh opened this issue Dec 28, 2020 · 1 comment

pham-tuan-binh commented Dec 28, 2020

I believe you forgot to multiply the timezone by 15 before converting it to radian.

Line 164 in sky-sim.html:
var time_zone_meridian = deg2rad(parseFloat($('#tz_sm').val()));

There were also some unused variables in your code, like "tz_offset", which I believe was faulty because of the wrong timezone calculation.

Anyway, super kudos for your amazing project.

The text was updated successfully, but these errors were encountered:

Owner

elonen commented Dec 28, 2020

If you have a tested patch / pull request, I'd appreciate it! I wrote this for one art project and haven't really touched it since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment