Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust hide username emojis pref to only hide in timeline #1631

Merged

Conversation

JohnyTheCarrot
Copy link
Contributor

@JohnyTheCarrot JohnyTheCarrot commented Feb 5, 2023

This PR makes it so descriptions are now properly supported in preferences, as well as applying the suggestion of making the hide username emojis pref only apply to the timeline.

@stackblitz
Copy link

stackblitz bot commented Feb 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit b200e2f
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63df8a995d8f8e00082a85da

@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit b200e2f
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63df8a99e581c80008ad162e
😎 Deploy Preview https://deploy-preview-1631--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JohnyTheCarrot JohnyTheCarrot changed the title feat(SettingsToggleItem): support descriptions feat: adjust hide username emojis pref to only hide in timeline Feb 5, 2023
@patak-dev
Copy link
Member

Is this showing emojis for you when looking at the profile with the option enabled?
https://deploy-preview-1631--elk-zone.netlify.app/universeodon.com/@[email protected]

How it should look https://main.elk.zone/mas.to/@Shini92

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the issue was that the SW was not updated yet. @userquin I thought we disabled it in previews, or when we check a PR we should still wait for the prompt after new commits are added?

@patak-dev patak-dev merged commit a1b2da3 into elk-zone:main Feb 5, 2023
@userquin
Copy link
Member

userquin commented Feb 5, 2023

@patak-dev Yes, the PWA will be there. You should always open PR previews with private browsing, the sw will be removed once you close the window.

@JohnyTheCarrot JohnyTheCarrot deleted the feat/preference-descriptions branch February 5, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants