fix: repeated content on reblog without comment (re-open) #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielroe
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a re-opened PR of the previous PR #1619 in which I forgot to rename my branch.)
Resolve #1541
When a user reblog a post without comment, some non-mastodon servers like Akkoma and GoToSocial copy the content of the original status to the content of the new reblogging status, instead of leaving it empty.
Currently, Elk treats this as reblogging with comment, and displays both
status.contentandstatus.reblog.content. As a result, the content is displayed twice.After this fix,
StatusCard.vuewill consider both reblog with emptystatus.contentand reblog with repeatedstatus.contentas reblog without comment, and display it with corresponding format.