Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bold and italic buttons to editor #1469

Merged
merged 9 commits into from
Feb 5, 2023

Conversation

victordelva
Copy link
Contributor

@victordelva victordelva commented Jan 26, 2023

imagen
imagen

@stackblitz
Copy link

stackblitz bot commented Jan 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 529464a
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63dfd4c1c2aa5a0008e5ed48

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 529464a
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63dfd4c109d45300094f40eb
😎 Deploy Preview https://deploy-preview-1469--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@victordelva victordelva changed the title add bold and italic buttons feat: add bold and italic buttons to editor Jan 26, 2023
@patak-dev
Copy link
Member

This looks good on big screens, but I'm afraid we are already out of space for mobile. @userquin also was working on some advanced features that would require space. And we got a request to hide the code block button. I think we should already have these two new ones and the code block behind a new format button that opens a toolbar on hover maybe?

@victordelva
Copy link
Contributor Author

@patak-dev
I'll try to work on that

@victordelva
Copy link
Contributor Author

I used a dropdown. this is how it looks on smaller screens.
What do you think @patak-dev ?

imagen

@patak-dev
Copy link
Member

It looks like there is a glitch in mobile, the keyboard collapses when the new button is pressed. Maybe is normal but we coupd check if that could be avoided

@boehs
Copy link
Member

boehs commented Jan 27, 2023

I think a simple e.preventDefault fixes

@boehs
Copy link
Member

boehs commented Feb 3, 2023

closes #1401

@patak-dev patak-dev enabled auto-merge (squash) February 5, 2023 16:04
@patak-dev patak-dev merged commit b7a3e93 into elk-zone:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants