Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #61

Open
uniqueg opened this issue Oct 9, 2018 · 1 comment
Open

Add tests #61

uniqueg opened this issue Oct 9, 2018 · 1 comment
Labels
flag: good 1st issue Good for newcomers type flag: meta Generic issue that will spawn more specific issues type: testing Related to code testing

Comments

@uniqueg
Copy link
Member

uniqueg commented Oct 9, 2018

Is your feature request related to a problem? Please describe.
Add unit and/or integration tests.

This is a "meta" issue, please leave it open and do not assign yourself to it. Instead, please open up a new issue for any one particular test that you wish to implement and assign yourself for that issue. Make sure that the issue has the bh19 label and starts with the name "Test" and some descriptive label, e.g., for a unit test that could be the tested function's name.

If you implement a new type of test, please add link to it in section Examples below.

Please add any helpful context, background info, framework in section Additional context below.

Describe the solution you'd like

  • Write unit tests for every function
  • Write integration tests for:
    • accessibility of the app
    • availability and functionality of all its required external services (database, broker, worker)
    • availability and functionality of any internal services (error handler, authorization, logging, monitoring)
    • availability and functionality of all endpoints and all associated responses
    • entire use cases
    • interaction with TES service

Describe alternatives you've considered
N/A

Examples
pytest: https://github.com/elixir-europe/TEStribute/tree/dev/tests

Additional context
Many of the tests will require a WES client, such as this: elixir-europe/WES-cli

@uniqueg uniqueg added this to the Release candidate v1.0.0-rc milestone Oct 9, 2018
@uniqueg uniqueg added this to To do in Pre-Hackathon Oct 9, 2018
@fgypas fgypas self-assigned this Oct 9, 2018
@fgypas
Copy link
Contributor

fgypas commented Nov 15, 2018

List of tests that will speed up the development and deployment:

Based on WES-cli

  • Get service info
  • Post workflow and check if it's running
  • Get run id and get status
  • Check if authentication is working (we need one instance with and one without authentication)

@fgypas fgypas removed their assignment Aug 1, 2019
@uniqueg uniqueg removed this from the Release candidate v1.0.0-rc milestone Sep 1, 2019
@uniqueg uniqueg added bh19 and removed critical labels Sep 1, 2019
@uniqueg uniqueg added this to To do in BH19 Japan Sep 1, 2019
@uniqueg uniqueg added medium and removed security labels Sep 1, 2019
@uniqueg uniqueg changed the title Add testing framework/solution and tests Add tests Sep 1, 2019
@uniqueg uniqueg added testing and removed long labels Sep 2, 2019
@uniqueg uniqueg removed bh19 labels Feb 20, 2020
@uniqueg uniqueg added flag: good 1st issue Good for newcomers type flag: meta Generic issue that will spawn more specific issues type: testing Related to code testing labels Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good 1st issue Good for newcomers type flag: meta Generic issue that will spawn more specific issues type: testing Related to code testing
Projects
No open projects
BH19 Japan
  
To do
Pre-Hackathon
  
To do
Development

No branches or pull requests

2 participants