-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about the label range. #6
Comments
Good catch! You're absolutely right, it looks like that's a bug which crept in during refactoring. I just pushed a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, Elijah!
Great work! After reading the source code, I have a question about the observed label's range in losses.py.
From my understanding, "label_vec_obs" is in {-1,1} and "label_vec_true" is in {0,1}.
But for losses 'bce' and 'bce_ls' , 'train_set_variant' is set as 'clean' and their label_vec _obs is same as label_vec_true.
However, in 'losses.py' ,
line 35, 48, assert not torch.any(observed_labels == 0),
line 134 assert torch.min(observed_labels) >= 0
Did I miss anything in observed label generating?
The text was updated successfully, but these errors were encountered: