Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The read marker is stuck in the past #8268

Closed
giomfo opened this issue Mar 23, 2023 · 4 comments
Closed

The read marker is stuck in the past #8268

giomfo opened this issue Mar 23, 2023 · 4 comments
Assignees
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@giomfo
Copy link
Member

giomfo commented Mar 23, 2023

Steps to reproduce

1- read all messages (reset a potential read marker by dismissing the "Jump to unread" banner)
2- navigate outside the room
3- send with another room member several messages (> 30), enough to not display the last read message
4- open again the room, the "Jump to unread" banner is displayed : OK
5- click on this banner, the timeline jump to the first unread message: OK (the unread messages marker may be displayed outside the screen just at the top. Scroll up to see it)
6- Jump back to live position by clicking on the icon displayed at the bottom right.

Outcome

What did you expect?

The read marker should be updated. The "jump to unread" banner should disappear if all messages have been read

What happened instead?

The read marker is stuck in the past, the "jump to unread" banner is still visible
Screen Recording_Android_ReadMarker

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes

@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 23, 2023
@giomfo
Copy link
Member Author

giomfo commented Mar 23, 2023

may be related to element-hq/element-ios#7420

@ganfra
Copy link
Member

ganfra commented Mar 31, 2023

When you use "Jump to bottom" button, it's made on purpose to not make your read marker updated as you are still not seing the messages in between. If you want to unstuck, just use the "jump to unread" close button.

@giomfo
Copy link
Member Author

giomfo commented Mar 31, 2023

When you use "Jump to bottom" button, it's made on purpose to not make your read marker updated as you are still not seing the messages in between. If you want to unstuck, just use the "jump to unread" close button.

The read marker should be updated at the most recent event visible before I use "Jump to bottom". In my video, the read marker should be moved to the "asd" message to prevent me from jumping back to the past.

There are several issues here:

  • the _unread messages_ marker is not visible sometimes after we "Jump to unread". It has to be visible to start tracking the last read event
  • the read marker should be updated when I "Jump to bottom" (return in live). We have to stop tracking the read events and update the read marker, like when the user moves outside the room

@ganfra
Copy link
Member

ganfra commented Apr 3, 2023

Ah yes true, I had misunderstood the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants