[Voice Broadcast] Update buffering display and improve playback #7655
Conversation
Florian14
added
the
Z-NextRelease
Florian14
force-pushed
the
feature/fre/voice_broadcast_buffering
branch
from
067f72e
to
42b3ecc
Compare
Florian14
requested review from
a team and
ganfra
and removed request for
a team
Florian14
changed the title
|
SonarCloud Quality Gate failed. |
| @@ -110,21 +111,23 @@ class AudioMessagePlaybackTracker @Inject constructor() { | |||
|
|
|||
| fun getPlaybackState(id: String) = states[id] | |||
|
|
|||
| fun getPlaybackTime(id: String): Int { | |||
| fun getPlaybackTime(id: String): Int? { | |||
There was a problem hiding this comment.
For Voice Broadcast, I need to distinguish a paused playback at 0sec from another which has no saved position, so I decided to return null in that case. The first time we play a voice broadcast which is live, the user should automatically jump to the last chunk, if he decided to manually scroll in the seekBar, the playback will start from that position (eg. 0 sec)
There was a problem hiding this comment.
Ok, maybe a sealed class would have been cleaner, but ok!
There was a problem hiding this comment.
I reused this object, I agree there are several things to improve: having the recording in the states list is a bit weird, same about having a percentage but not the duration, and like you said we don't really need this method and could have it in the sealed class (which already exists)
| import android.widget.LinearLayout | ||
| import im.vector.app.databinding.ViewVoiceBroadcastBufferingBinding | ||
|
|
||
| class VoiceBroadcastBufferingView @JvmOverloads constructor( |
There was a problem hiding this comment.
Nope, I don't really need to manipulate this custom view from code, it's just for consistency with the other metadata which are icon+text and not progress+text
Type of change
Content
pausebutton when the voice broadcast is buffering to let the user stop the bufferingMotivation and context
Design changes:
Screenshots / GIFs
Tests
Tested devices
Checklist