Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANR on session start when sending client info is enabled #7604

Closed
mnaturel opened this issue Nov 17, 2022 · 2 comments · Fixed by #7605
Closed

ANR on session start when sending client info is enabled #7604

mnaturel opened this issue Nov 17, 2022 · 2 comments · Fixed by #7605
Assignees
@mnaturel
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Android App Team Issue triage

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Nov 17, 2022 •
edited

Steps to reproduce

When client info recording is enabled (see Settings -> Labs) and when there is a version update, the app may encounter ANR on session start.

This is due to the fact ConfigureAndStartSessionUseCase is declared as a suspend method. To avoid that, the use case implementation should be changed a little.

Outcome

What did you expect?

No ANR.

What happened instead?

ANR when updating the app version on the start of the session and so when the application starts.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 17, 2022
@mnaturel mnaturel self-assigned this Nov 17, 2022
@RiotRobot RiotRobot added this to Important Issues & Topics (P1) in Android App Team Nov 17, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Nov 17, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Nov 17, 2022
@mnaturel mnaturel mentioned this issue Nov 17, 2022
Merged
15 tasks
@jmartinesp
Copy link
Contributor

This is probably the same as #7557.

@mnaturel
Copy link
Contributor Author

This is probably the same as #7557.

Perhaps it is related for some users but I think there may be different causes for other users. The suspend method was introduced in the version 1.5.4. The ANR should only be visible for next updates and only when the labs setting to send client info have been enabled manually (it is disabled by default).

Issue triage automation moved this from Triaged to Closed Nov 18, 2022
Android App Team automation moved this from Important Issues & Topics (P1) to Merged Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
Android App Team
Merged
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ANR on session start when sending client info is enabled element-hq/element-android
2 participants
@jmartinesp @mnaturel