Improve invite bottom sheet #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
reviewed
Sep 22, 2021
vector/src/main/java/im/vector/app/features/spaces/invite/SpaceInviteBottomSheetViewModel.kt
Show resolved
Hide resolved
bmarty
reviewed
Sep 23, 2021
| } | ||
|
|
||
| private fun refreshInviteSummaryIfNeeded(roomSummary: RoomSummary) { | ||
| if (roomSummary.membership == Membership.INVITE) { |
There was a problem hiding this comment.
To follow @ganfra 's remark, I would have let this if test at the calling place (i.e. in the init {} block) to reduce indentation in the body of this method. Also the method could then be renamed to fetchRoomSummary
|
|
||
| private fun refreshInviteSummaryIfNeeded(roomSummary: RoomSummary) { | ||
| if (roomSummary.membership == Membership.INVITE) { | ||
| // we can try to query the room summary api to get more info? |
ganfra
reviewed
Sep 24, 2021
| copy( | ||
| summary = Success( | ||
| roomSummary.copy( | ||
| joinedMembersCount = peekResult.numJoinedMembers, |
There was a problem hiding this comment.
Maybe have a small method to map PeekResult to RoomSummary also?
There was a problem hiding this comment.
Here we are copying an existing roomSummary with info from peekResult, so I think this is not applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick improvement of invite bottomsheet:
Whe showing an invite we try in background to query the room Summary API to get a bit more information (like the number of members). Also it could get a more up to date strippedState than the one in the room invite sync.