perf(manual-chunking): Remove country-flag-icons from manual chunking
#6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance increase itself is so small it's not really measurable with all other variations that exists but I manually verified the size changes and the import links and they look much nicer now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since this is now only imported into the Flag component we no longer need to add it as a manual chunk, this improve performance by budding it directly where it's used (together with the Flag component) and removes a lot of import links that was included in half the bundles for some reason.
Should yield a very minor performance boost when it comes to http downloads and first visits to the app.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.