Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While working on something else, I detected that the ES parser failed for some seemingly random dates. Upon closer inspection, I discovered that this happened because of a failure in the parsing of some dates:
ValueError: Invalid isoformat string: '2020-10-25 1A:00'
Apparently, the REE endpoint uses a strange format to distinguish the repeated hours during DST end days. It seemed quite unusual and I could not find it anywhere, so I built a parser for it.
Preview
An excerpt of the output from the parser after the changes:
Behaviour in other parsers
I looked for similar wrong behaviour during these dates in other parsers, in general the situation is quite a mess. In ESIOS and CY parsers it seems the endpoints themselves don't report data for 1 hour. It would be nice if someone with EIA and ENTSOE keys could tests those parsers. Many other parsers only work in realtime so they could not be tested.
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.