Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts don't re-size when the window size changes #5141

Open
VIKTORVAV99 opened this issue Feb 28, 2023 · 6 comments · May be fixed by #5166
Open

Charts don't re-size when the window size changes #5141

VIKTORVAV99 opened this issue Feb 28, 2023 · 6 comments · May be fixed by #5166

Comments

@VIKTORVAV99
Copy link
Member

Description

If you start with the app open in let's say split screen and then later expand the window to full screen you get a state where the charts are narrower than they should be.

For example:
image

Then if you refresh the page the charts render correctly:
image

@madsnedergaard
Copy link
Member

Maybe this could be fixed by replacing our custom ref resize observer with a third-party tool like https://github.com/ZeeCoder/use-resize-observer :)

@15Arindam
Copy link

Hey, I would like to try this, I'm new in OS contrib., could you please guide me how to setup locally & reproduce this issue

@VIKTORVAV99
Copy link
Member Author

Hey, I would like to try this, I'm new in OS contrib., could you please guide me how to setup locally & reproduce this issue

Hey @15Arindam!

Local setup should be documented in the CONTRIBUTING.md file. There isn't really much more too it than that for the frontend 🙂.

As for reproducing the issue that's pretty easy so all you need to do is the same as I did in the description of this issue.

If you have any questions feel free to reach out any time!

@15Arindam
Copy link

Thanks @VIKTORVAV99
I was able to locally setup, did some changes (need more help on it) but unable to push them.

@VIKTORVAV99
Copy link
Member Author

Thanks @VIKTORVAV99 I was able to locally setup, did some changes (need more help on it) but unable to push them.

Hi again @15Arindam
If you are trying to push directly to this repo that is expected and by design.
If you haven't already you need to fork the repository and then clone that instead of this one.
Once that is done you can push your changes to your fork and then open a pull request, PR, to this repository. That will also make sure all our automated tests run and give me and other members of the team time to review it before it's merged. (It's actually required.)

You can follow the detailed steps here: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

Just make sure you make a copy of your local changes first.

@15Arindam 15Arindam linked a pull request Mar 6, 2023 that will close this issue
2 tasks
@15Arindam
Copy link

Hey @VIKTORVAV99 ,
I've raised this PR please have a look if its okay

@VIKTORVAV99 VIKTORVAV99 linked a pull request Mar 25, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants