This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
add all the flags #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging as I don't think this requires a review. One note for ourselves is to be sure we use all the flag sizes. I don't think we are using 128?? |
|
Makes sense. Also, food for thought: could we use the flag emojis for this instead? 🤔 |
That is actually a really good point. Do you see any reason why not? I'd be down to try and then see if we run into roadblocks. |
|
I have no idea how to do it in a smart way though, but let's look into it at some point! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the flags