Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Changing only environment variable doesn't invalidate build #76

Open
corradio opened this issue Jan 3, 2021 · 0 comments
Open

Changing only environment variable doesn't invalidate build #76

corradio opened this issue Jan 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@corradio
Copy link
Member

corradio commented Jan 3, 2021

The caching mechanism checks for file inputs, and might abort a docker build if the inputs haven't changed.
However, other informations might invalidate the build, such as e.g. an environment variable.
The dependency hash should therefore include all information (and not only paths):
https://github.com/tmrowco/brick/blob/master/brick/dockerlib.py#L54-L79

@corradio corradio added the bug Something isn't working label Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant