This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Fix promotion not working when using a build tag #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reying on the last tag in the list, we should consider all repositories. This solves an issue where the last tag in the list was actually another repository (due to the build.tag option in the BUILD.yml file), and we thereby lost the promotion cache.
skovhus
force-pushed
the
ks/fix-promotion
branch
from
203237a
to
0a2ce9d
Compare
|
FYI @corradio |
madsnedergaard
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68
Details on the issue
The issue here is the confusing ordered list
tags(should be namedimageNamesas it containsrepo:tag). Previously when determining images we could promote we expected the repository in thetagsto be the same. This is not the case when the user defines atagin the build section of the configuration.